Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added command line scripts for concatening irc paths #168

Merged
merged 26 commits into from
Mar 21, 2024

Conversation

SiebeLeDe
Copy link
Contributor

@YHordijk Could you take a look and see if you can implement a simple python function that does the

optimize --mol ... -level ...

etc?

I now only included a directory where the scripts can be placed in including a script to concatenate irc files. This now only accepts two files, but the functions are written to include multiple. So, we could easily change it

@YHordijk YHordijk linked an issue Mar 14, 2024 that may be closed by this pull request
Copy link
Contributor

@YHordijk YHordijk Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the tcutility.results module to load your calculations. The Result objects also contain the history variable that should make it easy to access history variables.
E.g.

converged_energies = [energy for converged, energy in zip(res.history.converged, res.history.energy) if converged]

This should save you some work dealing with setting up plams.

return concatenated_mols, concatenated_energies


def _xyz_format(mol: Molecule) -> str:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These molecule writing functions would be nice to have in the tcutility.molecule module

@YHordijk YHordijk added the enhancement New feature or request label Mar 15, 2024
@SiebeLeDe SiebeLeDe merged commit 3c743ff into main Mar 21, 2024
6 checks passed
@SiebeLeDe SiebeLeDe deleted the 154-add-command-line-scripts branch March 21, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add command line scripts to the package
2 participants